New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly include ctype.h to fix compilation warning #2314
Conversation
IMHO worth mentioning in the changelog if we get a 4.x release with this fix :) |
@dentarg great call -- updated. |
Co-authored-by: Patrik Ragnarsson <patrik@starkast.net>
I believe that this is tied to the compiler version, not necessarily to the OS version. For example, I'm still running Catalina (10.15.5), but have the Xcode 12 beta and get the same error. Once Xcode 12 is released, I expect many people using macOS will upgrade to it and experience this problem. |
There is a similar issue reported macournoyer/thin#364 It says this is due to Xcode 12 change described here.
A simple workaround is here.
|
@nateberkopec WDYT about a 4.3.6 release with only this change? |
@@ -1,7 +1,7 @@ | |||
## Master | |||
|
|||
* Bugfixes | |||
* Explicitly include ctype.h to fix compilation warning and build error on MacOS Big Sur (#2304) | |||
* Explicitly include ctype.h to fix compilation warning and build error on macOS with Xcode 12 (#2304) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
4.3.5 and a 5.0.0.beta2 will be out Soon (tm) |
Apologies for commenting on a closed PR... I noticed this change was merged into a branch called |
Sorry, I meant 4.3.6! |
Explicitly include ctype.h to fix compilation warning
This fixes a compilation error - see puma/puma#2314
Description
This simply adds
#include <ctype.h>
to puma_http11.cOn the 4.x branch, we get the following warning during compilation:
On MacOS Big Sur, this results in a build failure with:
This change has already been applied to 5.0.0.beta / master as part of befe00a
Closes #2304
This PR is going to the 4.3.5 branch -- unsure if that's where you'd like it merged.
Your checklist for this pull request
[changelog skip]
the pull request title.[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.